fix: Firebase plugin fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor the object mappings to properly do item recursive mappings - Refactor the Firebase log calls to do some validation previously missing - Refactor the item mapping as it wasn't previously setting any properties. - Removes the `json_annotation` dependency from Firebase plugin - Sanitize event name - Adds default `logEvent` for any event name not in a standard case for Firebase - Removed `metrics` from the `RawEvent` class - Removes several files that should be ignored in the repo (WIP)
wenxi-zeng
approved these changes
Jun 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_annotationdependency from Firebase pluginlogEventfor any event name not in a standard case for Firebasemetricsfrom theRawEventclass